注册 登录
编程论坛 C++教室

求大神指教!这个程序哪里错了????????

IT男year 发布于 2013-10-16 12:42, 344 次点击
#include<iostream>
using namespace std;
class student
{
private:
    int age;
    char * name;
public:
    student(int m,char * n);
    student();
    ~student();
    void setmember(int m,char * n);
    int Getage();
    char * Getname();
};
student::student(int m,char * n)
{
    age=m;
    name=new char[strlen(n)+1];
    strcpy(name,n);
}
student::~student()
{
    delete []name;
}
student::student()
{
    age=0;
    name=new char[10];
    name="未给定初值";
}
void student::setmember(int m,char * n)
{
    age=m;
    name=n;
}
int student::Getage()
{
    return age;
}
char * student::Getname()
{
    return name;
}
int main()
{
    student S[3]={student(25,"肖某"),student(23,"何某")};
    for(int i=0;i<3;i++)
    {
        cout<<S[i].Getname()<<"  "<<S[i].Getage()<<'\n';
    }
    return 0;
}

[ 本帖最后由 IT男year 于 2013-10-16 12:44 编辑 ]
3 回复
#2
veketdelphi2013-10-16 15:39
无参构造函数有问题
student::student()
{
    age=0;
    name=new char[10];//
    name="未给定初值";//这两句有问题 name的指向发生变化 ,从指向new出来的数组 变为指向 字符串常量"未给定初值"
}

这就导致 析构函数试图去析构调 字符串常量"未给定初值"所在的内存块

修改成
student::student()
{
    age=0;
    name=new char[100];
    strcpy(name, "未给定初值");
}
#3
IT男year2013-10-16 16:13
回复 2楼 veketdelphi
非常感谢大神啦!
#4
staticor2013-10-16 16:31
程序代码:
#include <iostream>

using namespace std;

class Student
{
private:
    int mAge;
    char* mName;
public:
    Student (int age, char* name);
    Student ();
    ~Student ();
    void SetMember (int m, char* n);
    int GetAge();
    char* GetName();
};

Student::Student(int age, char* name)
{
    mAge = age;
    mName = new char [256];
    strcpy (mName, name);
}

Student::Student ()
{
    mAge = 0;
    mName = new char [256];
    strcpy (mName, "未给初始值");
}

Student::~Student ()
{
    delete[] mName;
}

void Student::SetMember (int age, char* name)
{
    mAge = age;
    mName = name;
}

int Student::GetAge ()
{
    return mAge;
}

char* Student::GetName ()
{
    return mName;
}

int main()
{
    Student S[3] = {Student(25,"肖某"), Student(23,"何某")};
    for (int i = 0; i < 3; i++)
    {
        cout << S[i].GetName() << " " << S[i].GetAge() << endl;
    }
    return 0;
}
楼上所言极是.顺便敲全代码
1